Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean output directories per sample #103

Closed
jasmezz opened this issue Jul 29, 2022 · 3 comments
Closed

Clean output directories per sample #103

jasmezz opened this issue Jul 29, 2022 · 3 comments
Labels
enhancement Improvement for existing functionality

Comments

@jasmezz
Copy link
Collaborator

jasmezz commented Jul 29, 2022

Description of feature

We need to clean up some output directories where multiple files per sample need to be put in individual sample folders.
For example this:
image
is supposed to look like this:
image

This is currently necessary for:

  • ampir
  • gecco
  • hamronization
  • prodigal
  • rgi
  • prodigal
@jasmezz jasmezz added the enhancement Improvement for existing functionality label Jul 29, 2022
@jfy133
Copy link
Member

jfy133 commented Jul 29, 2022

Devils advocate: this isn't necessary, as we should standardise/summarise everything with hAMRronization/AMPcombi etc., so maybe it's better to leave the output as expected for the tool (so a user can follow output docs of the given tool)

@jasmezz
Copy link
Collaborator Author

jasmezz commented Jul 29, 2022

I understand, not completely convinced though. With fARGene we are already doing it (it's just adding ${meta.id} to the modules.config). Because fARGene output would look completely messy without the subfolders. So either remove its ${meta.id} or add it to all tools?

@jasmezz
Copy link
Collaborator Author

jasmezz commented Aug 11, 2022

Closed by #107.

@jasmezz jasmezz closed this as completed Aug 11, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants