Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.8 #270

Merged
merged 7 commits into from May 2, 2023
Merged

Important! Template update for nf-core/tools v2.8 #270

merged 7 commits into from May 2, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.8 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.8 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.

For more information about this release of nf-core/tools, please see the v2.8 release page.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4abee09

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-02 10:46:29

@jasmezz jasmezz self-assigned this Apr 28, 2023
jasmezz
jasmezz reviewed May 2, 2023
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
jasmezz and others added 3 commits May 2, 2023 08:49
@jasmezz
Switch quay default off (temporarily), fix typo
03f86fa 
Because not all modules use quay as container repo (like gunzip, tar), those have to be updated before the new feature works.
@jasmezz
Fix linting (update modules)
46fd731
@jasmezz
Update modules (for new quay feature to work)
4abee09
jfy133
jfy133 approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG missing but otherwise LGTM

@jasmezz
Copy link
Collaborator

jasmezz commented May 2, 2023

Changelog just appeared before you commented 👍

@jasmezz jasmezz merged commit d79057b into dev May 2, 2023
@jasmezz jasmezz deleted the nf-core-template-merge-2.8 branch May 2, 2023 13:19
@jasmezz jasmezz mentioned this pull request May 17, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@jasmezz jasmezz jasmezz approved these changes

Assignees

@jasmezz jasmezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nf-core-bot @jasmezz @jfy133