Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ampir module #273

Merged
merged 3 commits into from May 10, 2023
Merged

Update ampir module #273

merged 3 commits into from May 10, 2023

Conversation

louperelo
Copy link
Contributor

Update amplify in the pipeline after module bugfix

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @louperelo,

It looks like this pull-request is has been made against the louperelo/funcscan master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the louperelo/funcscan dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@jasmezz jasmezz changed the base branch from master to dev May 10, 2023 12:45
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 36779d8

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-10 13:19:19

@jasmezz jasmezz changed the title Update amplify module Update ampir module May 10, 2023
jasmezz
jasmezz approved these changes May 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@louperelo @jasmezz
Apply suggestions from code review
36779d8 
Co-authored-by: Jasmin Frangenberg <73216762+jasmezz@users.noreply.github.com>
@louperelo louperelo merged commit 21a71e7 into nf-core:dev May 10, 2023
24 checks passed
@louperelo louperelo deleted the updateamplify branch May 10, 2023 13:20
@jasmezz jasmezz mentioned this pull request May 17, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@jasmezz jasmezz jasmezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louperelo @jfy133 @jasmezz