Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update (almost) all modules #274

Merged
merged 5 commits into from May 15, 2023
Merged

Update (almost) all modules #274

merged 5 commits into from May 15, 2023

Conversation

jasmezz
Copy link
Collaborator

@jasmezz jasmezz commented May 12, 2023

This updates all modules that were affected by the change of quay as default docker repo.
Additionally updated the link in local module dramp_download.nf.

PR checklist

  • [y] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Member

you forgot combgc.nf

@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 930b091

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-12 15:17:10

@jasmezz jasmezz requested a review from a team May 12, 2023 14:50
louperelo
louperelo approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@louperelo louperelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jasmezz jasmezz merged commit c28ffa5 into dev May 15, 2023
24 checks passed
@jasmezz jasmezz deleted the update-modules branch May 15, 2023 10:56
@jasmezz jasmezz mentioned this pull request May 17, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louperelo louperelo louperelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasmezz @maxulysse @louperelo