Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Prokka to MultiQC #295

Merged
merged 6 commits into from Jul 19, 2023
Merged

add Prokka to MultiQC #295

merged 6 commits into from Jul 19, 2023

Conversation

louperelo
Copy link
Contributor

@louperelo louperelo commented Jul 13, 2023 •
edited by jfy133

partly Closes issue #277

The Prokka module was added to the MultiQC output. For the other annotation tools (Prodigal, Pyrodigal, Bakta) there are no MultiQC modules yet.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@louperelo louperelo requested review from jfy133 and jasmezz July 13, 2023 13:25
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 74b59d0

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-19 09:12:55

@louperelo
Copy link
Contributor Author

@nf-core-bot fix linting

@louperelo
Copy link
Contributor Author

@nf-core-bot fix linting

jfy133
jfy133 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, other annotation modules can come later

workflows/funcscan.nf Outdated Show resolved Hide resolved
@louperelo @jfy133
Apply suggestions from code review
74b59d0 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@louperelo louperelo merged commit c61ea09 into nf-core:dev Jul 19, 2023
21 of 24 checks passed
@louperelo louperelo deleted the prokka_mqc branch July 19, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@jasmezz jasmezz Awaiting requested review from jasmezz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louperelo @jfy133 @nf-core-bot