Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base container image update #315

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Base container image update #315

merged 5 commits into from
Jun 3, 2022

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 3, 2022

PR checklist

To address GCP problem reported here https://nfcore.slack.com/archives/CE9MS66BS/p1654118333832289

with fix successful fix from RNASeq: nf-core/rnaseq#764

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 changed the base branch from master to dev June 3, 2022 06:47
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/nf-core-mag master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/nf-core-mag dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c666942

+| ✅ 146 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.2.0'
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-03 09:35:56

skrakau
skrakau approved these changes Jun 3, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 @skrakau
Update CHANGELOG.md
c666942 
Co-authored-by: Sabrina Krakau <sabrinakrakau@gmail.com>
@jfy133 jfy133 merged commit 18a8634 into nf-core:dev Jun 3, 2022
@jfy133 jfy133 deleted the base-container-image-update branch June 3, 2022 10:30
@d4straub d4straub mentioned this pull request Jun 13, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrakau skrakau skrakau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfy133 @skrakau