Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Busco error handling - do not ignore #72

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Jul 14, 2020

Turned off ignoring of BUSCO errors.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

@skrakau skrakau requested a review from d4straub July 14, 2020 09:45
@skrakau skrakau added this to Existing pipelines in hackathon-tasks Jul 14, 2020
@skrakau
Copy link
Member Author

skrakau commented Jul 14, 2020

This causes the pipeline to fail in cases such as described in #68 (which still occurs on CFC, but that need to be addressed properly).

@skrakau skrakau merged commit fbbf302 into nf-core:dev Jul 14, 2020
@skrakau skrakau mentioned this pull request Jul 17, 2020
@skrakau skrakau deleted the busco_error_handling branch November 4, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
hackathon-tasks
Existing pipelines
Development

Successfully merging this pull request may close these issues.

None yet

2 participants