Supporting alteration for the template and PR suggestions #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template update
Template update
Fix: remove faulty template inclusions and include PR suggestions
Alter: bump version to 2.3.0
Include: dependancies in CHANGELOG
|
d4straub
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
LGTM
Seems like changing .nf-core.yml was not on your agenda?
| @@ -16,12 +15,17 @@ | |||
| ### `Fixed` | |||
|
|
|||
| - Typo in previous release date | |||
| - [#208](https://github.com/nf-core/mhcquant/pull/208) - nf-core template update (version 2.3.2) | |||
There was a problem hiding this comment.
I doubt that. It is not appearing in the list of changes and #204 should be closed after you have synced the template update into dev. Did you follow https://nf-co.re/developers/sync#merging-automated-prs?
There was a problem hiding this comment.
For the changelog, I pulled the TEMPLATE to my own branch, but I already did a lot of changes before but that was manual 😅 .
Regarding the change of the .nf-core.yml, that will be addressed after this PR 😄
Since you already made the suggestion for it, I will accept that from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
copytoparams.publish_dir_mode,PR checklist
nf-core lint).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).