Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.7.2 #249

Merged
merged 5 commits into from Feb 27, 2023
Merged

Important! Template update for nf-core/tools v2.7.2 #249

merged 5 commits into from Feb 27, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.7.2 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.7.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.

For more information about this release of nf-core/tools, please see the v2.7.2 release page.

@nf-core-bot nf-core-bot mentioned this pull request Dec 19, 2022
Closed
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d2fa36e

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-27 11:54:04

jonasscheid
jonasscheid requested changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@jonasscheid jonasscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextflow version 21.10.3 does not match workflow required version: >=22.10.1

The test with additional parameters fails, because the template update bumped the nextflow version in ci.yml to the latest.
We need to adjust the nf version in the the ci test with additional parameters

@marissaDubbelaar marissaDubbelaar merged commit a58922c into dev Feb 27, 2023
@jonasscheid jonasscheid mentioned this pull request Apr 4, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasscheid jonasscheid jonasscheid approved these changes

@steffenlem steffenlem Awaiting requested review from steffenlem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nf-core-bot @jonasscheid @marissaDubbelaar