Get Singularity CI tests working #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
added
help wanted
edmundmiller
force-pushed
the
ci-fixes
branch
from
27526d6
to
9b45441
Compare
This reverts commit 9b45441.
….yml" This reverts commit ffc218e.
This will cause a bit of duplication, but it appears to work. Still the same logic, because any changes to bowtie*/build will run the align modules also. So the bowtie_align tags may not even be necessary, since we can't seem to get the bowtie*_build tags to kick off on their own anyways. Thank you for coming to my TED talk.
edmundmiller
force-pushed
the
ci-fixes
branch
from
de4a513
to
d48e865
Compare
edmundmiller
force-pushed
the
ci-fixes
branch
from
c888116
to
d48e865
Compare
KevinMenden
reviewed
Feb 4, 2021
| md5sum: a23e9a2a76e949aeb3693bcfae41a615 | ||
| md5sum: a81cb18024616415a6cec3108a36fccd |
There was a problem hiding this comment.
Any idea why this changed?
There was a problem hiding this comment.
# reads processed: 10000
# reads with at least one alignment: 2 (0.02%)
# reads that failed to align: 9998 (99.98%)
Reported 2 alignments
This is the latest version which is only showing 2 alignments...are you able to run pytest via the old tests so we can see the difference?
There was a problem hiding this comment.
The old version generated the output below which is why the tests are failing:
# reads processed: 10000
# reads with at least one alignment: 1 (0.01%)
# reads that failed to align: 9999 (99.99%)
Reported 1 paired-end alignments
I guess this highlights the importance of using seed values where possible in main.nf for the tests to always generate the same alignments and not by random. At least, this is what I think is happening here.
drpatelh
reviewed
Feb 4, 2021
drpatelh
reviewed
Feb 4, 2021
drpatelh
reviewed
Feb 4, 2021
Closed
drpatelh
approved these changes
Feb 4, 2021
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issues with singularity builds #145 and "fixes" the
bowtie*_buildtags not running.