Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module for panaroo, fix pirate tests #1444

Merged
merged 10 commits into from Mar 25, 2022

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Mar 24, 2022

PR checklist

Closes #1443

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

I opted for panaroo/run because panaroo has a few other sub-commands that might be added in the future. I also cleaned up some lingering comments in the PIRATE test main.nf

@rpetit3 rpetit3 added the new module Adding a new module label Mar 24, 2022
@rpetit3 rpetit3 changed the title add module for panaroo add module for panaroo, fix pirate tests Mar 24, 2022
@rpetit3
Copy link
Contributor Author

rpetit3 commented Mar 24, 2022

Pirate conda is failing with this:

 - ERROR: extract_feature_sequences.pl failed

Going to try pinning a specific build. Haha honestly didn't mean for this to turn into a new module and fix for old module!

@rpetit3
Copy link
Contributor Author

rpetit3 commented Mar 25, 2022

Had to pin bioperl to 1.7.2. The containers are not affected by this due to having 1.7.2

@rpetit3
Copy link
Contributor Author

rpetit3 commented Mar 25, 2022

Pirate issue is addressed here: #1094

Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rpetit3 rpetit3 merged commit d16f1ea into nf-core:master Mar 25, 2022
@rpetit3 rpetit3 deleted the rp3-add-panaroo branch March 25, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: panaroo
2 participants