Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(homer): Add groseq subworkflow #1492

Merged
merged 8 commits into from
Apr 4, 2022
Merged

feat(homer): Add groseq subworkflow #1492

merged 8 commits into from
Apr 4, 2022

Conversation

edmundmiller
Copy link
Contributor

Adding homer groseq subworkflow here, so it can be supported by tests more easily and because it's a pure nf-core subworkflow.

@edmundmiller
Copy link
Contributor Author

Confirmed the singularity tests work locally.

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just the indentations :D . Gavin added meta.ymls to the gatk4 subworklfows. https://github.com/nf-core/modules/blob/master/subworkflows/nf-core/gatk_tumor_normal_somatic_variant_calling/meta.yml

Even though we don't have an official template yet, i like having them around for some form of documentaiton at least

subworkflows/nf-core/homer/groseq/main.nf Outdated Show resolved Hide resolved
subworkflows/nf-core/homer/groseq/main.nf Outdated Show resolved Hide resolved
edmundmiller and others added 2 commits April 4, 2022 12:45
Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
@edmundmiller edmundmiller merged commit 13cc323 into master Apr 4, 2022
@edmundmiller edmundmiller deleted the homer/groseq branch April 4, 2022 18:21
edmundmiller added a commit to nf-core/nascent that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants