Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module for plasmidfinder #1773

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Jun 13, 2022

PR checklist

Closes #1772

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Few things.

Hard-coded bioconda build number

I had to force the build number in relation to bioconda/bioconda-recipes#35314 Previous builds didn't not include the required database, and it being only ~500kb, I submitted a new build to include it.

bioconda::plasmidfinder=2.1.6=py310hdfd78af_1

Avoid name collisions

PlasmidFinder does not include a --prefix parameter, so I manually move the output files to include the $prefix this should help avoid downstream name collisions.

@rpetit3
Copy link
Contributor Author

rpetit3 commented Jun 13, 2022

The file is available https://anaconda.org/bioconda/plasmidfinder/files

Maybe a CDN issue, I'll check back in a few days

@rpetit3 rpetit3 added new module Adding a new module Ready for Review labels Jun 14, 2022
@rpetit3
Copy link
Contributor Author

rpetit3 commented Jun 14, 2022

and the CDN is synced!

Copy link
Contributor

@sguizard sguizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpetit3 rpetit3 merged commit 052b9f2 into nf-core:master Jun 15, 2022
@rpetit3 rpetit3 deleted the rp3-add-plasmidfinder branch June 15, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: PlasmidFinder
2 participants