Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add module for seroba #1816

Merged
merged 6 commits into from
Sep 26, 2022
Merged

add module for seroba #1816

merged 6 commits into from
Sep 26, 2022

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Jun 27, 2022

PR checklist

Closes #1815

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added new module Adding a new module Ready for Review labels Jun 28, 2022
sguizard
sguizard approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@sguizard sguizard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you see if my two comments have to be corrected.
Otherwise, LGTM.

modules/seroba/run/main.nf Outdated Show resolved Hide resolved
modules/seroba/run/meta.yml Outdated Show resolved Hide resolved
rpetit3 and others added 4 commits July 5, 2022 09:47
@SPPearce SPPearce merged commit e3e6106 into nf-core:master Sep 26, 2022
@rpetit3 rpetit3 deleted the rp3-add-seroba branch September 26, 2022 15:23
matthdsm pushed a commit to matthdsm/nf-core-modules that referenced this pull request Sep 28, 2022
@rpetit3 @sguizard @matthdsm
add module for seroba (nf-core#1816)
5ec4bfa 
* add module for seroba

* fix lint

* Update modules/seroba/run/meta.yml

Co-authored-by: Sébastien Guizard <sguizard@ed.ac.uk>

* Update modules/seroba/run/main.nf

Co-authored-by: Sébastien Guizard <sguizard@ed.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguizard sguizard sguizard approved these changes

Assignees
No one assigned
Labels
new module Adding a new module Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: Seroba
3 participants
@rpetit3 @sguizard @SPPearce