Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap ngscheckmate/ncm to nftest #5679

Merged
merged 2 commits into from
May 23, 2024
Merged

Swap ngscheckmate/ncm to nftest #5679

merged 2 commits into from
May 23, 2024

Conversation

SPPearce
Copy link
Contributor

Working on bringing NGSCheckMate modules to nf-test

@SPPearce SPPearce requested a review from a team as a code owner May 23, 2024 08:33
@SPPearce SPPearce requested review from leoisl and removed request for a team May 23, 2024 08:33
when {
process {
"""
input[0] = BCFTOOLS_MPILEUP1.out.vcf.combine(BCFTOOLS_MPILEUP2.out.vcf.map{it[1]}).map{meta, one, two -> [meta, [one, two]]}.map{meta, stuff -> [meta, stuff.flatten()]}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is horrific and could do with cleaning up...
I have two outputs that are both:
[meta, vcf]
and I want to make
[new_meta, [vcf1, vcf2]]

Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't worry about weird channel magic. It's fine as long as it works :p

@SPPearce SPPearce added this pull request to the merge queue May 23, 2024
Merged via the queue into master with commit 0e04b94 May 23, 2024
12 checks passed
@SPPearce SPPearce deleted the ngscheckmate_nftest branch May 23, 2024 12:31
tstoeriko pushed a commit to tstoeriko/nf-core-modules that referenced this pull request May 23, 2024
* Swap ngscheckmate/ncm to nftest

* Update main.nf.test
setup {

run("BEDTOOLS_MAKEWINDOWS") {
script "../../../bedtools/makewindows/main.nf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SPPearce @nvnieuwk : Will that work in a pipeline where bedtools isn't installed? I'm having problems running this nf-test in Sarek where we don't have bedtools installed. The nf-test ran better after I installed bedtools in Sarek, but that doesn't seem like the right solution to me 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point! Maybe this is something that can be handled by nf-core tools (@mirpedrol)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.
The alternative would be to add files to test_data instead, but there are quite a few modules that do this kind of setup block. This is essentially taking a bed file and splitting it into individual bases.
I guess BCFTOOLS_MPILEUP exists in sarek already, so you didn't have an issue with that part.

Copy link
Contributor

@asp8200 asp8200 Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BCFTOOLS_MPILEUP is installed in Sarek, so that didn't cause any issues. However, I guess the nf-test should be kind of self-contained, and not rely on what other modules might or might not be installed in the particular pipeline that is trying to use the module.

I also had to change all params.test_data... to params.modules_testdata_base_path... to get the test kind of work, that is, I managed to get 3 out of 4 "subtests" working:

maxulysse/nf-core_sarek#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants