-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: Ultra
#871
New module: Ultra
#871
Conversation
- Update to last versions.yml file - Update meta.yml - Correct typos
\$(pwd)/$genome \\ | ||
\$(pwd)/$gtf \\ | ||
\$(pwd)/$reads \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need ${pwd}
here? The tool requires the full path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes. The tool do not resolve the file path properly yet, so full path to files is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-tested this with variations, but I could also only get it to work with $(pwd) (no ./$gtf, no $gtf)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted a new issue at the ULTRA-repo, with a fix-suggestion. Could be quick, but as I said on the mergathon call, I don't think it's a blocker for merging in - everything else looks good,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the issue 👍
I also think it could be merge in this temporary state.
In any case, I will update the module as soon as the patch is applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have added quite a bit of non-conventional code to get this module working @sguizard . Be great if we can try and make things simpler. Not entirely sure why the tool has been written this way but maybe we can discuss on the PR.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
The conda test failed because it couldn't download the fastq.gz file. |
Those data might be useful in a debugging purpose.
Looks awesome! Thanks @sguizard ! |
@sguizard there's actually a new release now, that's supposed to avoid the $pwd problem. But I guess that can wait for next release. |
New module for uLTRA: An efficient alignment method for spliced long reads
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd