Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multiqc report #23

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Improve multiqc report #23

merged 6 commits into from
Jun 7, 2023

Conversation

christopher-mohr
Copy link
Collaborator

Just a couple of small improvements for the multiqc report.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 6, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b4cec4f

+| ✅ 158 tests passed       |+
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-07 12:01:31

jfy133
jfy133 reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a CHANGELOG update to draw people';s attention the output might look different might nice, but MultiQC wise looks good 👍 (I'm assuming teh write_out_prepared_gex is related to that)

@christopher-mohr
Copy link
Collaborator Author

Maybe a CHANGELOG update to draw people';s attention the output might look different might nice, but MultiQC wise looks good 👍 (I'm assuming teh write_out_prepared_gex is related to that)

Thank you!

@christopher-mohr christopher-mohr merged commit 4580494 into nf-core:dev Jun 7, 2023
6 checks passed
@christopher-mohr christopher-mohr deleted the improve_multiqc_report branch June 7, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christopher-mohr @jfy133