Commits on Nov 1, 2023

1. remove unused code

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for e49c80e
   • Browse repository at this point

   Copy the full SHA

   e49c80e View commit details

   Browse the repository at this point in the history

2. promote DiannDirectory to a full class …

   As it is, there is too much logic in this class for it to be a dataclass.

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1ae7d3f
   • Browse repository at this point

   Copy the full SHA

   1ae7d3f View commit details

   Browse the repository at this point in the history

3. remove unused argument and simplify function …

   The only_first argument was never used in any function call in the script. It is also very easy to get the whole list of files matching a glob, if necessary.

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 5ffe5e6
   • Browse repository at this point

   Copy the full SHA

   5ffe5e6 View commit details

   Browse the repository at this point in the history

4. more descriptive function name

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 5354db3
   • Browse repository at this point

   Copy the full SHA

   5354db3 View commit details

   Browse the repository at this point in the history

5. do not overwrite builtin function dir

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 0be1267
   • Browse repository at this point

   Copy the full SHA

   0be1267 View commit details

   Browse the repository at this point in the history

6. remove unnecessary parenthesis in tuple unpacking

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 519ec23
   • Browse repository at this point

   Copy the full SHA

   519ec23 View commit details

   Browse the repository at this point in the history

7. do not repeatedly zip

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for a1225b1
   • Browse repository at this point

   Copy the full SHA

   a1225b1 View commit details

   Browse the repository at this point in the history

8. fix and add type annotations and add type conversions

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 2fde23c
   • Browse repository at this point

   Copy the full SHA

   2fde23c View commit details

   Browse the repository at this point in the history

9. improve readability of validate_diann_version

   

   fabianegli committed Nov 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c5053c7
   • Browse repository at this point

   Copy the full SHA

   c5053c7 View commit details

   Browse the repository at this point in the history

10. format with black

    

    fabianegli committed Nov 1, 2023
    Configuration menu

    • View commit details
    • Copy full SHA for dcaca0e
    • Browse repository at this point

    Copy the full SHA

    dcaca0e View commit details

    Browse the repository at this point in the history

11. extract the diann version as a property …

    and make validate_diann_version a method

    

    fabianegli committed Nov 1, 2023
    Configuration menu

    • View commit details
    • Copy full SHA for 958b16e
    • Browse repository at this point

    Copy the full SHA

    958b16e View commit details

    Browse the repository at this point in the history

12. more consistent spacing for if, else in nf files

    

    fabianegli committed Nov 1, 2023
    Configuration menu

    • View commit details
    • Copy full SHA for ad06fe0
    • Browse repository at this point

    Copy the full SHA

    ad06fe0 View commit details

    Browse the repository at this point in the history