Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #18

Merged
merged 15 commits into from
May 9, 2024
Merged

Bug fixes #18

merged 15 commits into from
May 9, 2024

Conversation

itrujnara
Copy link
Collaborator

PR checklist

  • Fixed many small bugs. Also contains the possibly incomplete changelog for 1.0.0.
  • Make sure your code lints (nf-core lint).

@itrujnara itrujnara marked this pull request as draft May 8, 2024 13:05
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 0491d3c

+| ✅ 209 tests passed       |+
!| ❗  13 tests had warnings |!
-| ❌   3 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • nfcore_yml - nf-core version not set in .nf-core.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.0
  • Run at 2024-05-09 09:01:35

@itrujnara itrujnara marked this pull request as ready for review May 8, 2024 13:27
JoseEspinosa
JoseEspinosa reviewed May 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
JoseEspinosa
JoseEspinosa approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! let's merge it even with errors since this is due to the recent release of tools v2.14.0 and they will be fixed once the template is merged

CHANGELOG.md Outdated Show resolved Hide resolved
@JoseEspinosa JoseEspinosa merged commit 9d02b6f into nf-core:dev May 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itrujnara @JoseEspinosa