Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularized database information, updated iqtree and fastme modules #5

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

itrujnara
Copy link
Collaborator

PR checklist

  • Database information is now processed in a fully modular way, allowing anyone to easily integrate new fetching modules without changing any existing ones. New versions of iqtree and fastme that use the meta map have been added, and code has been updated to match.
  • If you've fixed a bug or added code that should be tested, add tests! We get there when we get there.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
    Note: There is no documentation at all so nothing to update.

Copy link
Contributor

@luisas luisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@itrujnara itrujnara merged commit 3c83717 into nf-core:dev Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants