Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'fasta' should not be required if --genome supplied #1142

Closed
pinin4fjords opened this issue Dec 20, 2023 · 2 comments · Fixed by #1143
Closed

'fasta' should not be required if --genome supplied #1142

pinin4fjords opened this issue Dec 20, 2023 · 2 comments · Fixed by #1143
Labels
bug Something isn't working
Milestone
3.14.0

Comments

@pinin4fjords
Copy link
Member

pinin4fjords commented Dec 20, 2023 •
edited
Loading

Description of the bug

A recent commit has made the 'fasta' field required in the schema. That's evaluated before there's a chance to read the igenomes config for anything specified via --genome, so the form validation fails due to the missing field content, when it should pass and derive the fasta file from iGenomes.

For example, this makes submission of the 'test_full' profile impossible via the Seqera Platform UI.

Command used and terminal output

No response

Relevant files

No response

System information

No response
@pinin4fjords pinin4fjords added the bug Something isn't working label Dec 20, 2023
@pinin4fjords pinin4fjords mentioned this issue Dec 21, 2023
Merged
10 tasks
@pinin4fjords pinin4fjords linked a pull request Dec 21, 2023 that will close this issue
Move fasta check back to Groovy #1143
Merged
10 tasks
@pinin4fjords
Copy link
Member Author

pinin4fjords commented Dec 21, 2023 •
edited
Loading

Currently not possible - see https://nfcore.slack.com/archives/C056RQB10LU/p1703070599275599

@pinin4fjords pinin4fjords mentioned this issue Dec 21, 2023
Open
@drpatelh drpatelh added this to the 3.13.3 milestone Jan 3, 2024
@drpatelh
Copy link
Member

drpatelh commented Jan 3, 2024

Fixed in #1143

@drpatelh drpatelh closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.14.0
Development

Successfully merging a pull request may close this issue.

Move fasta check back to Groovy nf-core/rnaseq
2 participants
@pinin4fjords @drpatelh