Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextflow_schema.json linting fails with oneOf in required #2619

Closed
pinin4fjords opened this issue Dec 21, 2023 · 1 comment
Closed

nextflow_schema.json linting fails with oneOf in required #2619

pinin4fjords opened this issue Dec 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@pinin4fjords
Copy link
Member

Description of the bug

See this PR for the concrete example and slack discussion for more context.

To summarise, trying to require or or other of a pair of fields, but not both, using oneOf fails to pass linting.

Command used and terminal output

$ nf-core lint --dir .    

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.11.dev0 - https://nf-co.re
    There is a new version of nf-core/tools available! (2.11.1)


INFO     Testing pipeline: .                                                                                                                                              
Running lint checks ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 8 of 19 » pipeline_todosERROR    [✗] Pipeline schema does not follow nf-core specs:                                                                                                               
          Default parameters are invalid: {'hisat2_build_memory': '200.GB', 'gtf_extra_attributes': 'gene_name', 'gtf_group_features': 'gene_id',                         
         'featurecounts_group_type': 'gene_biotype', 'featurecounts_feature_type': 'exon', 'igenomes_base': 's3://ngi-igenomes/igenomes', 'trimmer': 'trimgalore',        
         'min_trimmed_reads': 10000, 'ribo_database_manifest': '${projectDir}/assets/rrna-db-defaults.txt', 'umitools_extract_method': 'string',                          
         'umitools_grouping_method': 'directional', 'aligner': 'star_salmon', 'min_mapped_reads': 5.0, 'kallisto_quant_fraglen': 200, 'kallisto_quant_fraglen_sd': 200,   
         'deseq2_vst': True, 'rseqc_modules': 'bam_stat,inner_distance,infer_experiment,junction_annotation,junction_saturation,read_distribution,read_duplication',      
         'skip_bbsplit': True, 'skip_preseq': True, 'custom_config_version': 'master', 'custom_config_base': 'https://raw.githubusercontent.com/nf-core/configs/master',  
         'test_data_base': 'https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq3', 'max_cpus': 16, 'max_memory': '128.GB', 'max_time': '240.h',                
         'publish_dir_mode': 'copy', 'max_multiqc_email_size': '25.MB', 'validate_params': True} is not valid under any of the given schemas                              
ERROR    [✗] Pipeline schema does not follow nf-core specs:                                                                                                               
          Default parameters are invalid: {'hisat2_build_memory': '200.GB', 'gtf_extra_attributes': 'gene_name', 'gtf_group_features': 'gene_id',                         
         'featurecounts_group_type': 'gene_biotype', 'featurecounts_feature_type': 'exon', 'igenomes_base': 's3://ngi-igenomes/igenomes', 'trimmer': 'trimgalore',        
         'min_trimmed_reads': 10000, 'ribo_database_manifest': '${projectDir}/assets/rrna-db-defaults.txt', 'umitools_extract_method': 'string',                          
         'umitools_grouping_method': 'directional', 'aligner': 'star_salmon', 'min_mapped_reads': 5.0, 'kallisto_quant_fraglen': 200, 'kallisto_quant_fraglen_sd': 200,   
         'deseq2_vst': True, 'rseqc_modules': 'bam_stat,inner_distance,infer_experiment,junction_annotation,junction_saturation,read_distribution,read_duplication',      
         'skip_bbsplit': True, 'skip_preseq': True, 'custom_config_version': 'master', 'custom_config_base': 'https://raw.githubusercontent.com/nf-core/configs/master',  
         'test_data_base': 'https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq3', 'max_cpus': 16, 'max_memory': '128.GB', 'max_time': '240.h',                
         'publish_dir_mode': 'copy', 'max_multiqc_email_size': '25.MB', 'validate_params': True} is not valid under any of the given schemas                              
CRITICAL Critical error: [✗] Pipeline schema does not follow nf-core specs:                                                                                               
          Default parameters are invalid: {'hisat2_build_memory': '200.GB', 'gtf_extra_attributes': 'gene_name', 'gtf_group_features': 'gene_id',                         
         'featurecounts_group_type': 'gene_biotype', 'featurecounts_feature_type': 'exon', 'igenomes_base': 's3://ngi-igenomes/igenomes', 'trimmer': 'trimgalore',        
         'min_trimmed_reads': 10000, 'ribo_database_manifest': '${projectDir}/assets/rrna-db-defaults.txt', 'umitools_extract_method': 'string',                          
         'umitools_grouping_method': 'directional', 'aligner': 'star_salmon', 'min_mapped_reads': 5.0, 'kallisto_quant_fraglen': 200, 'kallisto_quant_fraglen_sd': 200,   
         'deseq2_vst': True, 'rseqc_modules': 'bam_stat,inner_distance,infer_experiment,junction_annotation,junction_saturation,read_distribution,read_duplication',      
         'skip_bbsplit': True, 'skip_preseq': True, 'custom_config_version': 'master', 'custom_config_base': 'https://raw.githubusercontent.com/nf-core/configs/master',  
         'test_data_base': 'https://raw.githubusercontent.com/nf-core/test-datasets/rnaseq3', 'max_cpus': 16, 'max_memory': '128.GB', 'max_time': '240.h',                
         'publish_dir_mode': 'copy', 'max_multiqc_email_size': '25.MB', 'validate_params': True} is not valid under any of the given schemas                              
INFO     Stopping tests...

System information

No response

@pinin4fjords pinin4fjords added the bug Something isn't working label Dec 21, 2023
@pinin4fjords pinin4fjords changed the title Linting fails with 'oneOf' in 'required'. nextflow_schema.json linting fails with 'oneOf' in 'required'. Dec 21, 2023
@ewels ewels changed the title nextflow_schema.json linting fails with 'oneOf' in 'required'. nextflow_schema.json linting fails with oneOf in required Mar 14, 2024
mberacochea added a commit to EBI-Metagenomics/miassembler that referenced this issue Jul 5, 2024
@ewels
Copy link
Member

ewels commented Aug 28, 2024

#2427 already mentioned this and I think it's best tackled together with anyOf, allOf so merging into that issue.

@ewels ewels closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants