Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrimGalore Speedup #344

Closed
apeltzer opened this issue Nov 23, 2019 · 4 comments
Closed

TrimGalore Speedup #344

apeltzer opened this issue Nov 23, 2019 · 4 comments
Labels
feature-request
Projects
hackathon-scilifelab-2019
Milestone
2.0

Comments

@apeltzer
Copy link
Member

Good results in another pipeline should be used here too ;-)

nf-core/atacseq#63 (comment)
@apeltzer apeltzer added this to the 1.5 milestone Nov 23, 2019
@apeltzer apeltzer added this to Beginner tasks in hackathon-scilifelab-2019 via automation Dec 4, 2019
@apeltzer apeltzer mentioned this issue Dec 4, 2019
Merged
9 tasks
@apeltzer
Copy link
Member Author

apeltzer commented Dec 4, 2019

Needs to wait for #352 to be merged in order to be able to test it, but then the code could simply be ported over from the linked issue in here 👍

@phue
Copy link
Member

phue commented Dec 5, 2019

⚠️ Careful with this, doesn't work with python 2.x environments ⚠️

nf-core/methylseq#130 (comment)

(currently conda will create an python 2.x environment in the container because HISAT2 doesn't build for python 3.x)

@apeltzer
Copy link
Member Author

apeltzer commented Dec 5, 2019

🎉 - Phil made a PR on bioconda to get that done :-)

bioconda/bioconda-recipes#19100

@drpatelh
Copy link
Member

Added b1f3af6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
No open projects
hackathon-scilifelab-2019
  
Beginner tasks
Milestone
2.0
Development

No branches or pull requests
3 participants
@apeltzer @phue @drpatelh