Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Salmon to infer strandedness #637

Closed
kathleencheung opened this issue May 13, 2021 · 3 comments
Closed

Allow Salmon to infer strandedness #637

kathleencheung opened this issue May 13, 2021 · 3 comments
Milestone

Comments

@kathleencheung
Copy link

It would be great if there was an option to let Salmon automatically infer the library type instead of taking this from the input file.

E.g. --libType A

This is already inferred by RSeQC infer_experiment.py and the user can re-run the pipeline with the correct strandedness if it was incorrect, however, allowing Salmon to infer it will save this extra step when the user does not know the strandedness.

@drpatelh
Copy link
Member

drpatelh commented Jun 1, 2021

Hi @kathleencheung! Apologies for the late response. This seems like a decent proposition as is described here. We could possibly add a parameter to the pipeline such as --salmon_quant_libtype that allows users to override the default behaviour of the pipeline.

I am a bit hesitant to make --libType A the default because getting the strandedness correct will affect the results generated by other QC-based tools used in the pipeline too and this sort of thing can be easily overlooked and the wrong inferences will be made without re-running the pipeline with the correct strandedness e.g. qualimap, stringtie and featurecounts

How does that sound?

@kathleencheung
Copy link
Author

Thanks @drpatelh that sounds great!

@drpatelh
Copy link
Member

FIxed in #659 - using --salmon_quant_libtype A will now be able to give you this behaviour and in fact the ability to override any valid --libType setting. Just beware that some of the downstream QC metrics from other tools may not be entirely accurate if there is a discrepancy in the strandedness provided in the samplesheet compared to that auto-inferred by salmon quant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants