Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn --deseq2_vst on by default #841

Closed
ojziff opened this issue Jun 24, 2022 · 4 comments
Closed

Turn --deseq2_vst on by default #841

ojziff opened this issue Jun 24, 2022 · 4 comments
Milestone

Comments

@ojziff
Copy link

ojziff commented Jun 24, 2022

I ran rnaseq v3.8.1 on 400 samples. Failed as I got a timeout after 8hrs on DESEQ2_QC_STAR_SALMON process. It was still running rlog after 8 hours with the message:

rlog() may take a long time with 50 or more samples,
vst() is a much faster transformation

I have specified --deseq2_vst which works but i wondered if --deseq2_vst could be made default?

@RaverJay
Copy link

I second that it should be the default

Also, the timeout seems unnecessary - why produce an error when things could still finish correctly?

@StevenWingett
Copy link

I also agree with this proposal. I have been processing hundreds of RNA-seq datasets and this step of the pipeline fails after 8 hours.

Furthermore, since I have set automatic retries of [attempt number] * 8 hours - this would cause the pipeline to fail again after 16 hours and then again after 24 hours.

Consequently, the rnaseq pipeline terminates in error and takes around 2 days to process this PCA plot, which is only for QC purposes.

I think Oliver’s suggestion of having --deseq2_vst as the default option is a very good idea and should improve the pipeline substantially when processing a large number of samples.

Otherwise, thanks for maintaining this great pipeline!

Best,

Steven

@drpatelh
Copy link
Member

Agree too! Will be in the next release.

@drpatelh drpatelh added this to the 3.9 milestone Sep 25, 2022
@drpatelh drpatelh changed the title DESEQ2_QC_STAR_SALMON timeout with rlog and 400 samples Turn --deseq2_vst on by default Sep 25, 2022
drpatelh added a commit to drpatelh/nf-core-rnaseq that referenced this issue Sep 27, 2022
@drpatelh
Copy link
Member

Fixed in a4be75f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants