Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch modules to fix #1103 #1149

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Patch modules to fix #1103 #1149

merged 3 commits into from
Jan 3, 2024

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Jan 3, 2024

Fixes tests in #1148 which was a reversion of #1138

Idea is to temporarily patch fix this via nf-core modules patch and push all nf-test related changes to the nf-test branch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b6a2d52

+| ✅ 146 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnaseq.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-03 15:46:28

@pinin4fjords
Copy link
Member

Note the same fix applied to a local module here: 2e72110

@pinin4fjords
Copy link
Member

pinin4fjords commented Jan 3, 2024 •
edited
Loading

Changelog?

pinin4fjords
pinin4fjords approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpatelh drpatelh mentioned this pull request Jan 3, 2024
Merged
@drpatelh drpatelh merged commit ca7467a into nf-core:dev Jan 3, 2024
29 checks passed
@drpatelh drpatelh deleted the updates branch January 3, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drpatelh @pinin4fjords