Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release issue fixes #732

Merged
merged 10 commits into from
Dec 14, 2021
Merged

Pre-release issue fixes #732

merged 10 commits into from
Dec 14, 2021

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Dec 13, 2021

Closes #664
Closes #720
Closes #725
Closes #727

conf/modules.config Outdated Show resolved Hide resolved
@mahesh-panchal
Copy link
Member

mahesh-panchal commented Dec 13, 2021

Line 193 in modules.config also needs:

if (!(params.skip_fastqc || params.skip_qc)) {
    process {
        withName: '.*:FASTQC_UMITOOLS_TRIMGALORE:FASTQC' {
            ext.args   = '--quiet'
        }
    }
}

It's appearing in tests that are passing. https://github.com/nf-core/rnaseq/runs/4510962412?check_suite_focus=true

@mahesh-panchal
Copy link
Member

Also need the conditional for '.*:FASTQC_UMITOOLS_TRIMGALORE:TRIMGALORE'

if (!params.skip_trimming){
    process {
        withName: '.*:FASTQC_UMITOOLS_TRIMGALORE:TRIMGALORE' {
        ...

@mahesh-panchal
Copy link
Member

mahesh-panchal commented Dec 13, 2021

WARN: There's no process matching config selector: NFCORE_RNASEQ:RNASEQ:.*:BAM_SORT_SAMTOOLS:SAMTOOLS_SORT
WARN: There's no process matching config selector: NFCORE_RNASEQ:RNASEQ:.*:BAM_SORT_SAMTOOLS:SAMTOOLS_INDEX
WARN: There's no process matching config selector: NFCORE_RNASEQ:RNASEQ:.*:BAM_SORT_SAMTOOLS:BAM_STATS_SAMTOOLS:.*
WARN: There's no process matching config selector: .*:FASTQC_UMITOOLS_TRIMGALORE:FASTQC

with Test Salmon with workflow parameters (--skip_qc --skip_alignment)

The NFCORE_RNASEQ:RNASEQ:.*:BAM_SORT_SAMTOOLS:BAM_STATS_SAMTOOLS:.* selector may need to be split up into it's respective block.
e.g.
NFCORE_RNASEQ:RNASEQ:ALIGN_STAR:BAM_SORT_SAMTOOLS:BAM_STATS_SAMTOOLS:.*

@drpatelh
Copy link
Member Author

Forgot we are running all of these tests! Be great if you can create a separate in PR fixing up those WARN . I will go through them again after you are done. Think we need to add some more comments to modules.config to break things up a little because it's quite easy to get lost in all of the buried config.

@drpatelh drpatelh merged commit dbf85f9 into nf-core:dev Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants