Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'auto' option to fastq_dir_to_samplesheet.py and set as default argument #956

Merged
merged 3 commits into from Mar 14, 2023
Merged

Add 'auto' option to fastq_dir_to_samplesheet.py and set as default argument #956

merged 3 commits into from Mar 14, 2023

Conversation

ryanyord
Copy link
Contributor

Updated the fastq_dir_to_samplesheet.py to add the 'auto' option to concur with #729. Also, set this to be the default argument when generating the spreadsheet.

@drpatelh
Copy link
Member

Awesome! Thanks @ryanyord ! Be great if you can add a line in the CHANGELOG regarding these changes. I have sent you an invite to join the nf-core Github org too.

@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 78d4dc9

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '3.10.1'
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-14 19:14:17

@drpatelh
Copy link
Member

Python Black frustrations!! I'll merge and fix in a follow up PR.

@drpatelh drpatelh merged commit 7e187c6 into nf-core:dev Mar 14, 2023
23 of 24 checks passed
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@ryanyord ryanyord deleted the samplesheet branch March 14, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanyord @drpatelh