Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output from ascat not stable #702

Closed
asp8200 opened this issue Aug 11, 2022 · 5 comments · Fixed by nf-core/modules#3260 or #988
Closed

Output from ascat not stable #702

asp8200 opened this issue Aug 11, 2022 · 5 comments · Fixed by nf-core/modules#3260 or #988
Assignees
Labels
bug Something isn't working

Comments

@asp8200
Copy link
Contributor

asp8200 commented Aug 11, 2022

Description of the bug

When running the following test, which is also also part of the CI-test tests/test_tools_manually.yml,

nextflow run main.nf -profile test,tools_somatic_ascat

@SusiJo found that the content (not just timestamps or something like that, but proper values!) of the output-files

results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourBAF.txt
results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourLogR.txt

change on reruns:

image

Command used and terminal output

nextflow run main.nf -profile test,tools_somatic_ascat


"unstable" output-files
results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourBAF.txt
results/variant_calling/ascat/sample4_vs_sample3/sample4_vs_sample3.tumour_tumourLogR.txt

Relevant files

sample4_vs_sample3.tumour_tumourBAF.txt from consecutive runs of the test:

ascat2.zip
ascat1.zip

System information

No response

@asp8200 asp8200 added the bug Something isn't working label Aug 11, 2022
@FriederikeHanssen
Copy link
Contributor

what did you use to run it? Docker?

@asp8200
Copy link
Contributor Author

asp8200 commented Aug 11, 2022

what did you use to run it? Docker?

@SusiJo told me she used Docker.

@FriederikeHanssen
Copy link
Contributor

Looking at the manual here: https://raw.githubusercontent.com/VanLoo-lab/ascat/master/man/ASCAT-manual.pdf looks like one can set seeds for a few functions. Haven't cross-checked them with the ones that are used, but seems like a good place to start.

@SusiJo
Copy link
Contributor

SusiJo commented Oct 11, 2022

So they fixed the issue on the master branch but we probably need to wait for the 3.1 release to make a new mulled container.

@FriederikeHanssen
Copy link
Contributor

Hey! Let's keep this open until it is actually merged into the pipeline and added to the changelog or we will forget :)

@SusiJo SusiJo linked a pull request Apr 5, 2023 that will close this issue
9 tasks
@SusiJo SusiJo closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
3 participants