Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanopore reads are classified with a set of taxonomic profilers #22

Closed
7 of 9 tasks
Tracked by #20
sofstam opened this issue Mar 17, 2022 · 9 comments
Closed
7 of 9 tasks
Tracked by #20

Nanopore reads are classified with a set of taxonomic profilers #22

sofstam opened this issue Mar 17, 2022 · 9 comments
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@sofstam
Copy link
Collaborator

sofstam commented Mar 17, 2022

Classifiers that can be tested or investigated for nanopore reads:

  • MetaMaps
  • MEGAN-LR, further investigation is needed if this tool can be used in the pipeline
  • Kraken2
  • Centrifuge
  • Kaiju
    • kaiju/kaiju module needs to be added to taxprofiler
    • kaiju/kaiju2table module needs to be added to taxprofiler
@sofstam sofstam added the enhancement Improvement for existing functionality label Mar 17, 2022
@sofstam sofstam changed the title Reads are classified with at least one of the following taxonomic profilers: kraken2/centrifuge/kaiju/metamaps Nanopore reads are classified with at least one of the following taxonomic profilers: kraken2/centrifuge/kaiju/metamaps Mar 17, 2022
@Midnighter
Copy link
Collaborator

Relevant pre-print https://www.biorxiv.org/content/10.1101/2022.01.31.478527v1

@sofstam sofstam changed the title Nanopore reads are classified with at least one of the following taxonomic profilers: kraken2/centrifuge/kaiju/metamaps Nanopore reads are classified with at least one of the taxonomic profilers Mar 17, 2022
@jfy133
Copy link
Member

jfy133 commented Mar 18, 2022

Note that MEGAN itself is a GUI based tool, and may not be 💯 suitable for pipelining (however sometimes some of the functionality is present in utility tools packged with MEGAN, so it may still be possible - I actually plan to include the MEGAN container anyway, as it has a useful tool to convert MALT RMA6 files into tables) - so it's something worth investigating

@sofstam
Copy link
Collaborator Author

sofstam commented Mar 18, 2022

I was thinking more of investigating MEGAN at this point, I will update the description of the issue.

@gregmedlock
Copy link

FYI the preprint that @Midnighter linked used PacBio's snakemake workflow for HiFi/nanopore reads with MEGAN-LR, and describes which executable tools + files are used from the MEGAN community edition, so it should be possible : )

Also, this may be out-of-scope until after a stable release, but a bespoke implementation of BugSeq-V2 seems worth investigating given its performance in that preprint.

@sofstam sofstam self-assigned this Mar 22, 2022
@jfy133 jfy133 added the first-release Functionality defined in initial design label Apr 16, 2022
@sofstam sofstam changed the title Nanopore reads are classified with at least one of the taxonomic profilers Nanopore reads are classified with a set of taxonomic profilers Apr 19, 2022
@jfy133 jfy133 added this to the First Release milestone May 1, 2022
@jfy133
Copy link
Member

jfy133 commented May 6, 2022

Removing this from the first release milestone as the only current candidate, metaMaps is stuck due to an upstream bug (see)

@jfy133 jfy133 removed this from the First Release milestone May 6, 2022
@jfy133 jfy133 added first-release Functionality defined in initial design and removed first-release Functionality defined in initial design labels May 31, 2022
@jfy133
Copy link
Member

jfy133 commented Sep 4, 2022

There doesn't seem to be any further updates from metaMaps so going to close this (sadly)

@jfy133 jfy133 closed this as completed Sep 4, 2022
@Midnighter
Copy link
Collaborator

If we're closing this issue, can we open two new ones to remember @gregmedlock 's points above #22 (comment)

@jfy133
Copy link
Member

jfy133 commented Sep 5, 2022

@sofstam could you do that?

@jfy133
Copy link
Member

jfy133 commented Sep 5, 2022

note that when I look at the MEGNA-LR related snakemake pipeline, that's just actually minimap2 + a LCA... we could do that instead I guess but it's a whole extra (rather large workflow). Although admittedly with tools we already have in taxprofiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants