Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting should fail if pipeline module file is edited #1313

Closed
ewels opened this issue Nov 8, 2021 · 1 comment
Closed

Linting should fail if pipeline module file is edited #1313

ewels opened this issue Nov 8, 2021 · 1 comment
Labels
bug Something isn't working high-priority linting

Comments

@ewels
Copy link
Member

ewels commented Nov 8, 2021

In ewels/nf-core-methylseq#2 I have edited a module file that was pulled from nf-core/modules. I shouldn't be allowed to do this.

The linting warns me that something is amiss:

│ bismark/align                            │ modules/nf-cor… │ Local copy of   │
│                                          │                 │ module outdated │

But it should be checking the git sha in modules.json and recognising that it doesn't match what it expects. Then throwing a hard error.

Possible that the code for this is lurking in a PR that's waiting to be merged..

@ewels ewels added bug Something isn't working DSL2 linting labels Nov 8, 2021
@ewels ewels added this to the 2.3 milestone Dec 9, 2021
@ewels ewels removed this from the 2.3 milestone Dec 9, 2021
@ewels
Copy link
Member Author

ewels commented Dec 18, 2021

Done in #1373

@ewels ewels closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority linting
Projects
None yet
Development

No branches or pull requests

2 participants