Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .yamllint.yaml to avoid error when lines are longer than 80 characters #1407

Closed
JoseEspinosa opened this issue Feb 10, 2022 · 2 comments
Closed

Add .yamllint.yaml to avoid error when lines are longer than 80 characters #1407

JoseEspinosa opened this issue Feb 10, 2022 · 2 comments

Comments

@JoseEspinosa
Copy link
Member

Description of feature

I think that after bumping the new node version and the yamllint update in #1398 , we will need to include a .yamllint.yamlsimilarly to what we do with .markdownlint.yml here:

tools/nf_core/pipeline-template/.markdownlint.yml

Line 3 in e563811

line-length: false
and it is explained in yamllnt documentation

Otherwise, I tried to use the new linting.yml on this draft PR and I am getting plenty of errors for lines longer than 80 characters for many of the yaml configuration files on .github/workflows and also others.
@mashehu
Copy link
Contributor

mashehu commented Feb 10, 2022 •
edited
Loading

We can take the .yamllint.yml from nf-core/modules@530acec

@JoseEspinosa JoseEspinosa mentioned this issue Feb 10, 2022
Merged
2 tasks
@mashehu
Copy link
Contributor

mashehu commented Feb 11, 2022

fixed with #1408 + #1409

@mashehu mashehu closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mashehu @JoseEspinosa