-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are slow due to too many web queries and limits set by web resources #1697
Labels
Comments
OH! it's even worse. After deleting the cache and rerunning the tests with no internet connectivity:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of feature
Many tests will pull form the github repo. 55 in total. This means running the tests once already pulls 55 times, running them repeatedly every couple of minutes over the course of a day apparently isn't well appreciated by github. There are other connections, too, that are done by the tests: refgenie 1x, nf-co.re 12x, api.github.com 1x, pypi.org 2x.
The repeated pulls make the tests slow and repeating the pull can probably be avoided for many tests. One pull, should be enough, and the resulting directory used could e.g. just be copied locally. It would even be nice to have the tests be mostly reduced to local folders. Git supports local repos and as such it might be possible to have the complete test suite contained in this project. After all, if we allow arbitrary git repos, it should not be restricted to repos available over http(s).
There might be some parts of the code that might have to be adapted to allow local folders as resources.
The text was updated successfully, but these errors were encountered: