Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock biocontainers and anaconda api calls in module tests #1967

Merged
merged 6 commits into from
Oct 25, 2022

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Oct 25, 2022

Mock biocontainers and anaconda api calls to make tests faster.
Related to #1697

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1967 (4d675bd) into dev (81af6b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1967   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files          37       37           
  Lines        4678     4678           
=======================================
  Hits         2860     2860           
  Misses       1818     1818           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol changed the base branch from master to dev October 25, 2022 08:53
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :-) Locally tested the branch and its quite a bit faster and good that we do not depend on the API being online all the time 😓

tests/utils.py Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit 6a1b48b into nf-core:dev Oct 25, 2022
@mirpedrol mirpedrol deleted the mock-tests branch October 25, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants