Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create] Remove --no-git flag #2081

Closed
Tracked by #2340
fabianegli opened this issue Nov 30, 2022 · 2 comments
Closed
Tracked by #2340

[create] Remove --no-git flag #2081

fabianegli opened this issue Nov 30, 2022 · 2 comments
Labels
command line tools Anything to do with the cli interfaces

Comments

@fabianegli
Copy link
Contributor

Description of feature

As discussed in Slack (this and following posts) the option to create workflows without using git will be removed if no compelling use cases come to our attention.

Quote from @ewels about how the git-less creation came to be:

I think it was requested for people who had already initialised a git repo themselves previously
But it's generally A Bad Thing, as the fresh repo is needed for automated template synchronisation

Context: #2074 (comment)

@awgymer
Copy link
Contributor

awgymer commented Dec 8, 2022

I was just reading through the docs for nf-core sync and under the section on syncing retrospectively I noticed the following:

If your pipeline already has versioned releases (eg. you are not currently on 1.0dev), then specify the version number that you are currently on:
nf-core create --no-git --version 1.3dev

So I am wondering whether there may be a legitimate edge-case where we need to run create without actually initialising any git repo.

@ewels
Copy link
Member

ewels commented Jun 27, 2023

Yup, but syncing retrospectively is an utterly horrible experience that should be avoided at all costs 😆 It was more uncommon in the early days of nf-core when were first setting up the template sync mechanism, but in recent years I think that almost no-one has needed to do it.

Removing the --no-git option is one way of discouraging this. And doing the equivalent manually (eg. copying the files out and over) is not particularly difficult.

@ewels ewels added command line tools Anything to do with the cli interfaces and removed enhancement labels Jun 27, 2023
@ewels ewels changed the title Remove ability to create gitless workflows [create] Remove --no-git flag Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces
Projects
None yet
Development

No branches or pull requests

4 participants