Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor passing of command line arguments to nf-core commands #1145

Merged

Conversation

ErikDanielsson
Copy link
Contributor

@ErikDanielsson ErikDanielsson commented Jul 1, 2021

Updated passing of arguments to nf-core commands and subcommands:

  • Pipeline directory is now passed with --dir <pipeline directory> with . as default, for all nf-core commands that previously had it as an argument. Resolves Updating handling of <pipeline directory> in nf-core #1140
  • Pipeline directory for nf-core modules list is now passed with --installed <pipeline directory>. Partially resolves nf-core modules list behaviour #1139
  • --tool <tool name> for nf-core modules subcommand are now replaced by optional argument <tool>. For example: nf-core modules install fastqc.
  • Updated docs text, but not the console logs.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1145 (3d8b6af) into dev (9c83171) will decrease coverage by 0.42%.
The diff coverage is 39.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1145      +/-   ##
==========================================
- Coverage   69.72%   69.29%   -0.43%     
==========================================
  Files          50       50              
  Lines        5179     5224      +45     
==========================================
+ Hits         3611     3620       +9     
- Misses       1568     1604      +36     
Impacted Files Coverage Δ
nf_core/bump_version.py 91.52% <0.00%> (+3.00%) ⬆️
nf_core/modules/module_utils.py 41.02% <0.00%> (ø)
nf_core/__main__.py 56.79% <34.66%> (-5.23%) ⬇️
nf_core/lint/__init__.py 75.10% <50.00%> (-0.53%) ⬇️
nf_core/schema.py 84.97% <50.00%> (-0.39%) ⬇️
nf_core/modules/modules_command.py 72.22% <66.66%> (-1.12%) ⬇️
nf_core/utils.py 83.64% <80.00%> (-0.05%) ⬇️
nf_core/modules/bump_versions.py 79.51% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c83171...3d8b6af. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍 ✅

CHANGELOG.md Outdated Show resolved Hide resolved
@ErikDanielsson
Copy link
Contributor Author

Thanks for the review @KevinMenden!

nf_core/__main__.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nf_core/__main__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ErikDanielsson
Copy link
Contributor Author

Thanks again @KevinMenden!

Co-authored-by: Kevin Menden <kevin.menden@live.com>
@ErikDanielsson ErikDanielsson merged commit 6d30c3a into nf-core:dev Jul 2, 2021
@ErikDanielsson ErikDanielsson deleted the refactor-pipeline-directory branch July 26, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants