Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stub to the modules template #2277

Merged
merged 3 commits into from May 5, 2023
Merged

Add stub to the modules template #2277

merged 3 commits into from May 5, 2023

Conversation

nvnieuwk
Copy link
Contributor

@nvnieuwk nvnieuwk commented May 4, 2023

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@nvnieuwk
Copy link
Contributor Author

nvnieuwk commented May 4, 2023

Fixes #2192

JoseEspinosa
JoseEspinosa approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍
Feel free to merge after tests succed

@nvnieuwk
Copy link
Contributor Author

nvnieuwk commented May 4, 2023

Thanks @JoseEspinosa!

@codecov
Copy link

codecov bot commented May 4, 2023 •
edited

Codecov Report

Merging #2277 (4d495fb) into dev (ffc0256) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2277   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files          77       77           
  Lines        8432     8432           
=======================================
  Hits         6166     6166           
  Misses       2266     2266

@mirpedrol
Copy link
Member

Remember to update the changelog :)

@jfy133
Copy link
Member

jfy133 commented May 5, 2023

Credit yourself ;)

@nvnieuwk
Copy link
Contributor Author

nvnieuwk commented May 5, 2023

Thanks! 😁

@nvnieuwk nvnieuwk merged commit 41b4dfc into nf-core:dev May 5, 2023
15 checks passed
@nvnieuwk nvnieuwk deleted the add-stub-to-modules-template branch May 5, 2023 07:23
@edmundmiller edmundmiller added this to the 2.9 milestone Sep 22, 2023
This was linked to issues Sep 22, 2023
Add a --stub option to create-test-yml #2420
Closed
Add stub to module template #2192
Closed
@edmundmiller edmundmiller removed a link to an issue Sep 22, 2023
Add a --stub option to create-test-yml #2420
Closed
@mirpedrol mirpedrol mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

@jfy133 jfy133 jfy133 approved these changes

Assignees

@nvnieuwk nvnieuwk

Labels
None yet
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

Add stub to module template
5 participants
@nvnieuwk @mirpedrol @jfy133 @JoseEspinosa @edmundmiller