Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise docker_image_name to avoid UnboundLocalError error #2374

Merged
merged 4 commits into from Jul 18, 2023

Conversation

mirpedrol
Copy link
Member

Close #2369

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2374 (a01a513) into dev (a353abb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #2374   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files          78       78           
  Lines        8888     8889    +1     
=======================================
+ Hits         6471     6472    +1     
  Misses       2417     2417           
Impacted Files Coverage Δ
nf_core/utils.py 81.43% <100.00%> (+0.03%) ⬆️

@mirpedrol mirpedrol requested a review from mashehu July 18, 2023 07:28
nf_core/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol mirpedrol merged commit b8c278a into nf-core:dev Jul 18, 2023
20 checks passed
@mirpedrol mirpedrol deleted the docker_image_name branch July 18, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants