Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting the revision from prompts when running nf-core launch #2375

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix getting the revision from prompts when running nf-core launch #2375

merged 2 commits into from
Jul 17, 2023

Conversation

mirpedrol
Copy link
Member

Close #2360

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #2375 (e212203) into dev (0fe54b0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev    #2375   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files          78       78           
  Lines        8888     8888           
=======================================
  Hits         6471     6471           
  Misses       2417     2417
Impacted Files Coverage Δ
nf_core/launch.py 63.26% <0.00%> (ø)

@mirpedrol mirpedrol changed the title Fit getting the revision from prompts when running nf-core launch Fix getting the revision from prompts when running nf-core launch Jul 17, 2023
@mirpedrol mirpedrol merged commit acf0389 into nf-core:dev Jul 17, 2023
20 checks passed
@mirpedrol mirpedrol deleted the get-revision branch July 17, 2023 15:03
@alneberg alneberg mentioned this pull request Aug 30, 2023
Closed
@mirpedrol mirpedrol restored the get-revision branch November 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mirpedrol