Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default false from json schema #2376

Merged
merged 4 commits into from Jul 18, 2023

Conversation

mirpedrol
Copy link
Member

Since v2.9 defaults to false were introduced in the nextflow schema. They are not required, as any value not evaluating to true won't be printed by printSummaryParams(). Those defaults are also automatically removed by nf-core schema build.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2376 (1f3f0de) into dev (7e69eed) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2376      +/-   ##
==========================================
+ Coverage   72.81%   72.85%   +0.03%     
==========================================
  Files          78       78              
  Lines        8888     8888              
==========================================
+ Hits         6472     6475       +3     
+ Misses       2416     2413       -3     

see 3 files with indirect coverage changes

@mirpedrol mirpedrol merged commit a353abb into nf-core:dev Jul 18, 2023
20 checks passed
@mirpedrol mirpedrol deleted the schema-default-false branch July 18, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants