Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create: Mock git cretentials to generate stable textual snapshots #3007

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

mirpedrol
Copy link
Member

Close #2975

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not keep the current version to test a failing entry? Or do we test that already?

@mirpedrol
Copy link
Member Author

Sorry, I should have explained that in the PR description 😄
The problem with this test was that when running the tests locally it finds github credentials, it shows a message saying that credentials were found and fills the input boxes with these defaults. When the test is run on github it can't find the credentials, so this message is not shown and the generated screenshot is different.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.06%. Comparing base (feb5685) to head (8067c10).
Report is 31 commits behind head on dev.

Current head 8067c10 differs from pull request most recent head aec56ce

Please upload reports for the commit aec56ce to get more accurate results.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit 5201eb1 into nf-core:dev Jun 26, 2024
35 checks passed
@mirpedrol mirpedrol deleted the textual-snapshot-mock-git branch June 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants