Create: allow more special characters on the pipeline name for non-nf-core pipelines #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mashehu
approved these changes
May 29, 2024
nf_core/pipelines/create/utils.py
Outdated
|
|
||
|
|
||
| # Define a global variable to store the pipeline type | ||
| PIPELINE_TYPE_GLOBAL: Union[str, None] = None |
There was a problem hiding this comment.
How about making this an enum?
There was a problem hiding this comment.
Your comment made me think that it's actually better to use a boolean, because we only have nf-core or not nf-core, so there's no need to do complicated things :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2963
Use validation context from pydantic with Model initialization. See docs here
Adding a global variable was the only option to access the pipeline type from validation, where the app is not available, so we can't use class attributes.