Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wittyer fixed #51

Merged
merged 9 commits into from
Jun 24, 2024
Merged

wittyer fixed #51

merged 9 commits into from
Jun 24, 2024

Conversation

kubranarci
Copy link
Contributor

@kubranarci kubranarci commented Jun 18, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kubranarci kubranarci linked an issue Jun 18, 2024 that may be closed by this pull request
fix wittyer #50
Closed
@kubranarci kubranarci changed the title wittyer removed for now wittyer fixed Jun 21, 2024
@kubranarci kubranarci requested a review from heylf June 21, 2024 11:26
heylf
heylf reviewed Jun 21, 2024
View reviewed changes
Copy link

@heylf heylf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Else LGTM.

assets/schema_input.json Show resolved Hide resolved
assets/schema_input.json Show resolved Hide resolved
assets/schema_input.json Show resolved Hide resolved
assets/schema_input.json Show resolved Hide resolved
subworkflows/local/sv_germline_benchmark.nf Show resolved Hide resolved
@kubranarci kubranarci self-assigned this Jun 24, 2024
heylf
heylf approved these changes Jun 24, 2024
View reviewed changes
Copy link

@heylf heylf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubranarci kubranarci merged commit d29cad9 into dev Jun 24, 2024
4 checks passed
@kubranarci kubranarci deleted the 50-fix-wittyer branch June 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heylf heylf heylf approved these changes

Assignees

@kubranarci kubranarci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix wittyer
2 participants
@kubranarci @heylf