Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutter tests cannot find static functions #6

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 3 comments
Closed

cutter tests cannot find static functions #6

GoogleCodeExporter opened this issue Mar 14, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

When making checks:

make  check-TESTS
make[2]: Entering directory `.../nfc-tools/git-svn/libfreefare/test'
OOOOOOO/usr/bin/cutter: symbol lookup error: ./.libs/test_mad.so: undefined 
symbol: nxp_crc
FAIL: run-test.sh

This is because nxp_crc() is defined as static in libfreefare/mad.c
Same for sector_0x00_crc8() and sector_0x10_crc8()

Issue is solved by removing the keyword "static" in front of those three 
functions but I'm not sure it's the right thing to expose those internal 
functions.
If they are meant to be internal, why test_mad is calling them?

Original issue reported on code.google.com by yob...@gmail.com on 15 Jan 2013 at 8:12

@GoogleCodeExporter
Copy link
Author

Original report: https://code.google.com/p/nfc-tools/issues/detail?id=105

Original comment by yob...@gmail.com on 15 Jan 2013 at 8:13

@GoogleCodeExporter
Copy link
Author

Original comment by yob...@gmail.com on 15 Jan 2013 at 8:22

@GoogleCodeExporter
Copy link
Author

Fixed in r5fa9f2cbc34d.

Thanks!

Original comment by romu...@libnfc.org on 18 Feb 2013 at 4:09

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant