Do not use sizeof() on a pointer

The problem was spotted by cppcheck: Using 'sizeof' on array given as function argument returns size of a pointer.
nfc-tools · Apr 4, 2013 · 74efe0b · 74efe0b
1 parent 4254941
commit 74efe0b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/nfcforum_type4_tag.c b/src/nfcforum_type4_tag.c
@@ -95,9 +95,9 @@ nfcforum_type4_ndef_tag_application_select(nfc_device_t* pnd)
 }
 
 bool
-nfcforum_type4_select(nfc_device_t* pnd, const byte_t fileID[2])
+nfcforum_type4_select(nfc_device_t* pnd, const byte_t *fileID)
 {
   byte_t select_cmd[] = { CLEAR_TEXT, SELECT, 0x00, 0x00, 0x02, 0x00, 0x00 };
-  memcpy(select_cmd + 5, fileID, sizeof(fileID));
+  memcpy(select_cmd + 5, fileID, 2);
   return nfcforum_type4_transceive(pnd, select_cmd,sizeof(select_cmd), NULL, NULL);
 }