Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge vocexcel-parts used by voc4cat-tool #117

Closed
wants to merge 147 commits into from
Closed

Merge vocexcel-parts used by voc4cat-tool #117

wants to merge 147 commits into from

Conversation

dalito
Copy link
Member

@dalito dalito commented Jul 4, 2023

Abandoned in favor of #119

This PR contains an experiment to merge the parts of VocExcel that we use. This has several advantages compared to further maintaining our fork of VocExcel. Future changes will affect just one code base which makes development a lot easier. Also it helps to avoid confusion with different VocExcel (ours and RDFLib/VocExcel). Moreover, we no longer use the term Excel™ as part of a "product" which IMHO is problematic.

I have merged the respective files including the full git-history to this PR´s branch. Some files/directories were moved to match the directory layout of this repository. The following command was used to rewrite the history in a local clone of NFDICat/VocExcel:

git filter-repo \
  --path tests/test_models.py \
  --path tests/test_template043.py \
  --path tests/test_utils.py \
  --path .pre-commit-config.yaml \
  --path vocexcel/convert.py \
  --path vocexcel/convert_043.py \
  --path vocexcel/models.py \
  --path vocexcel/profiles.py \
  --path vocexcel/utils.py \
  --path vocexcel/validator.vocpub.ttl \
  --path templates/VocExcel-template_043.xlsx \
  --path-rename templates/VocExcel-template_043.xlsx:tests/templates/VocExcel-template_043.xlsx \
  --path-rename vocexcel/:src/voc4cat/

The tool git filter-repo can be simply pipx-installed: pipx install git filter-repo (at least on Windows).

nicholascar and others added 30 commits May 25, 2021 00:03
…o reflect, fixed Concept children URIs & openpyxl active sheet
@dalito dalito marked this pull request as draft July 4, 2023 07:11
@dalito dalito changed the title Merge vocexcel used by voc4cat Merge vocexcel-parts used by voc4cat-tool Jul 4, 2023
@dalito dalito self-assigned this Jul 4, 2023
@dalito dalito added enhancement Request for changing or improving existing features housekeeping Clean-up or maintenance tasks like updates etc. labels Jul 4, 2023
@dalito dalito closed this Jul 5, 2023
@dalito dalito deleted the merge-vocexcel branch July 5, 2023 11:33
@dalito dalito modified the milestone: 0.6.0 Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for changing or improving existing features housekeeping Clean-up or maintenance tasks like updates etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants