Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cli with subcommands #135

Merged
merged 4 commits into from
Aug 3, 2023
Merged

New cli with subcommands #135

merged 4 commits into from
Aug 3, 2023

Conversation

dalito
Copy link
Member

@dalito dalito commented Jul 20, 2023

The new cli has 4 sub-commands: transform, convert, check and docs. In contrast to the current CLI (0.5.0) the new sub-commands do one think at a time. There is no magic of chaining actions like in the current CLI, which made the code too complex and difficult to extend. The new sub-commands share a common set of options, like e.g. --help, --config or --logfile. The new code uses many of argparse's features which results in cleaner well-structured code. This will make future changes and additions much easier.

The new CLI can be run via the command voc4cat-ng (ng = next generation) until it becomes the default CLI in 0.6.0. The existing CLIs (voc4cat / vocexcel) remain unchanged in the 0.5.x series and will be removed in 0.6.0.

Still to do:

  • Draft structure of new command and its subcommands
  • Implement interface in argparse
  • Add test for new interface

Closes #128

@dalito dalito added the enhancement Request for changing or improving existing features label Jul 20, 2023
@dalito dalito self-assigned this Jul 20, 2023
@dalito dalito added this to the 0.5.0 milestone Jul 20, 2023
@dalito dalito modified the milestones: 0.5.0, 0.6.0 Jul 27, 2023
@dalito dalito force-pushed the issue128 branch 2 times, most recently from 9de69a0 to 62e5608 Compare July 27, 2023 11:18
@dalito dalito modified the milestones: 0.6.0, 0.5.1 Aug 3, 2023
@dalito dalito marked this pull request as ready for review August 3, 2023 16:17
@dalito dalito merged commit 8df54e3 into main Aug 3, 2023
3 checks passed
@dalito dalito deleted the issue128 branch August 3, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for changing or improving existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge command line interfaces (voc4cat & vocexcel)
1 participant