chore: drop unsupported node versions on macOS #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 1 1
Lines 56 56
=======================================
Hits 49 49
Misses 7 7 ☔ View full report in Codecov by Sentry. |
|
Edit: never mind, I'm going to rescope this PR so we can land it faster. |
No change to logic. This drops support for older NodeJS versions on macOS because GitHub Actions no longer supports them.
|
Actually, I'm going to reopen #16 and just descope this to dropping macOS. |
nfischer
force-pushed
the
chore-drop-node-v12
branch
from
a612395
to
e76495f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to logic. This drops support for older NodeJS versions on macOS because GitHub Actions no longer supports them.