Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEP0124] DeprecationWarning: REPLServer.rli is deprecated #6

Open
nfischer opened this issue Jan 14, 2022 · 1 comment
Open

[DEP0124] DeprecationWarning: REPLServer.rli is deprecated #6

nfischer opened this issue Jan 14, 2022 · 1 comment
Labels
bug

Comments

@nfischer
Copy link
Owner

Looks like this was deprecated in v12 and removed in v16. https://nodejs.org/api/deprecations.html#DEP0124. I think this usage is coming from tmpvar/repl.history#15.
@nfischer
Copy link
Owner Author

https://github.com/omni-tools/node-repl-story seems to be a replacement for the modern APIs.

@nfischer nfischer added the bug label Jan 14, 2022
TSRBerry pushed a commit to TSRBerry/pegaswitch that referenced this issue Feb 12, 2022
@jeliebig
Update node packages + Replace repl.history with repl-story
023d683 
With these changes pegaswitch can be launched again.
Since REPLServer.rli was deprecated and removed
repl.history doesn't work anymore and thus was replaced with repl-story.
See these issues:
- tmpvar/repl.history#15
- nfischer/n_shell#6
@TSRBerry TSRBerry mentioned this issue Feb 12, 2022
Open
@JessieFrance JessieFrance mentioned this issue Feb 20, 2022
Merged
nfischer pushed a commit that referenced this issue Feb 20, 2022
@JessieFrance
Test and lint (#11)
24adc87 
This PR aims to add tests and linting for #3 as well as GitHub CI. To summarize, the commits add: 

- Mocha tests, similar to the "integration" tests at n_. One test is skipped because it fails on a possible bug. I'm happy to delete that test, or to try to find a fix for it on this or another PR.  
- a GitHub workflow CI similar to the one from shelljs-plugin-inspect. I used this to help me see where tests were passing/failing on Windows and Mac since I use Linux, and to check that applying linting didn't break stuff. Experiments with this CI workflow showed me that the tests work on NodeJS 10 through 14 but fail on NodeJS versions >=15 for Mac, Windows, and Linux with an error message related to `repl.history` in #6. I'm happy to delete/modify this commit though if you don't want it.
- linting styles (copied over from the test folder at ShellJS).
- The new linting applied to index.js.

As always, I'm happy to make any changes. It's been fun learning about REPLs. Thank you for the opportunity to learn more about a really cool project!
TSRBerry added a commit to TSRBerry/pegaswitch that referenced this issue Jul 20, 2022
@TSRBerry
Update node packages + Replace repl.history with repl-story
7905d87 
With these changes pegaswitch can be launched again.
Since REPLServer.rli was deprecated and removed
repl.history doesn't work anymore and thus was replaced with repl-story.
See these issues:
- tmpvar/repl.history#15
- nfischer/n_shell#6
@nfischer nfischer mentioned this issue Aug 10, 2022
Open
@nfischer nfischer mentioned this issue Jun 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfischer