Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title doesn't update when opening in a new tab until focused #315

Open
kombucha opened this issue Sep 13, 2017 · 2 comments
Open

Title doesn't update when opening in a new tab until focused #315

kombucha opened this issue Sep 13, 2017 · 2 comments

Comments

@kombucha
Copy link

@kombucha kombucha commented Sep 13, 2017

When opening a link from my app in a new tab (via cmd+click for example), the new tab title is not correctly updated from its default title. When selecting the tab, the title gets updated correcly.
It seems to be cause by the introduction of requestAnimationFrame in the pull request #307. At least in chrome, requestAnimationFrame is not executed on background tabs.
I've tested with a previous version (5.0.0), which has the correct behaviour.
(bug observed by @samuelmartineau)

@samzhao

This comment has been minimized.

Copy link

@samzhao samzhao commented Oct 15, 2017

I just realized that there's another issue related to this that was answered already: #314.

TL;DR: add defer={false} prop to skip requestAnimationFrame.

freiksenet added a commit to gatsbyjs/gatsby that referenced this issue Jun 11, 2019
…sed (#14661)

When opening a link from Gatsby site in a new tab (via cmd+click for example), the new tab title is not correctly updated from its default title. 
Related to:
nfl/react-helmet#315
nfl/react-helmet#314
mxxk added a commit to mxxk/gatsby that referenced this issue Jun 21, 2019
…sed (gatsbyjs#14661)

When opening a link from Gatsby site in a new tab (via cmd+click for example), the new tab title is not correctly updated from its default title. 
Related to:
nfl/react-helmet#315
nfl/react-helmet#314
johno added a commit to johno/gatsby that referenced this issue Jul 17, 2019
…sed (gatsbyjs#14661)

When opening a link from Gatsby site in a new tab (via cmd+click for example), the new tab title is not correctly updated from its default title. 
Related to:
nfl/react-helmet#315
nfl/react-helmet#314
@cyranix

This comment has been minimized.

Copy link

@cyranix cyranix commented Aug 16, 2019

This solution still works, but it's not documented in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.